Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Misc] Remove abused noqa #6619

Merged
merged 1 commit into from
Jul 21, 2024
Merged

[Misc] Remove abused noqa #6619

merged 1 commit into from
Jul 21, 2024
+6 −5

Conversation

WoosukKwon
Copy link
Collaborator

This PR removes abused noqas and reformats the code.

@WoosukKwon WoosukKwon added the ready ONLY add when PR is ready to merge/full CI is needed label Jul 21, 2024
@WoosukKwon WoosukKwon requested a review from youkaichao July 21, 2024 10:05
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which consists a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of default ones by unblocking the steps in your fast-check build on Buildkite UI.

Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge).

To run full CI, you can do one of these:

  • Comment /ready on the PR
  • Add ready label to the PR
  • Enable auto-merge.

🚀

DarkLight1337
DarkLight1337 approved these changes Jul 21, 2024
View reviewed changes
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup!

@DarkLight1337 DarkLight1337 merged commit b6df37f into main Jul 21, 2024
85 checks passed
@youkaichao
Copy link
Member

Thanks for the cleanup!

@youkaichao youkaichao deleted the minor-noqa branch July 21, 2024 17:25
xjpang pushed a commit to xjpang/vllm that referenced this pull request Jul 24, 2024
@WoosukKwon
[Misc] Remove abused noqa (vllm-project#6619)
873ba29
gnpinkert pushed a commit to gnpinkert/vllm that referenced this pull request Jul 26, 2024
@WoosukKwon @gnpinkert
[Misc] Remove abused noqa (vllm-project#6619)
8ed81e3
cduk pushed a commit to cduk/vllm-pascal that referenced this pull request Aug 6, 2024
@WoosukKwon
[Misc] Remove abused noqa (vllm-project#6619)
802dfb7
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
@WoosukKwon @Alvant
[Misc] Remove abused noqa (vllm-project#6619)
d1bb9f6 
Signed-off-by: Alvant <[email protected]>
KuntaiDu pushed a commit to KuntaiDu/vllm that referenced this pull request Nov 20, 2024
@WoosukKwon
[Misc] Remove abused noqa (vllm-project#6619)
32a4ab0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

@youkaichao youkaichao Awaiting requested review from youkaichao

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WoosukKwon @youkaichao @DarkLight1337